detect: Recognize ERSPAN Type I packets #4466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorjulien
reviewed
Jan 7, 2020
| @@ -890,6 +890,7 @@ void CaptureStatsSetup(ThreadVars *tv, CaptureStats *s); | |||
| enum DecodeTunnelProto { | |||
| DECODE_TUNNEL_ETHERNET, | |||
| DECODE_TUNNEL_ERSPAN, | |||
| DECODE_TUNNEL_ERSPAN_TYPEI, | |||
There was a problem hiding this comment.
So is our default ERSPAN actually type 2? Maybe we can just name these DECODE_TUNNEL_ERSPAN2 and DECODE_TUNNEL_ERSPAN1 then?
| /** | ||
| * \brief ERSPAN Type I | ||
| */ | ||
| int DecodeERSPANTypeI(ThreadVars *tv, DecodeThreadVars *dtv, Packet *p, const uint8_t *pkt, uint32_t len, PacketQueue *pq) |
There was a problem hiding this comment.
For new code, lets make sure we wrap lines.
|
Continued in #4474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ERSPAN Type I packets.
This document and wireshark were used as a reference for this work.
Link to redmine ticket:3422
Describe changes:
Suricata-verify pr 169