Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard check #10

Closed
wants to merge 3 commits into from
Closed

Wildcard check #10

wants to merge 3 commits into from

Conversation

andrewaeva
Copy link

Added the ability to check Wildcard before bruteforcing

@OJ
Copy link
Owner

OJ commented Jan 6, 2016

Nifty! Thanks for the PR. As soon as I have internet on at home (11th Jan) I'll give this a spin. Thank you!

@OJ OJ self-assigned this Jan 6, 2016
@OJ OJ added the enhancement label Jan 6, 2016
andrewaeva@ya.ru and others added 2 commits January 14, 2016 20:02
@OJ
Copy link
Owner

OJ commented Jan 15, 2016

Hey @andrewaeva,

Thanks again for the PR. I'm open to the wildcard check, but the output to file thing is not something I'd include at this point, especially given it's just for DNS. To accept the "output to file" functionality it'd have to be in a new PR and it'd have to be supported on both DNS and DIR modes.

Cheers

@OJ
Copy link
Owner

OJ commented Jan 15, 2016

Also, in future, please can you do pull requests from feature branches instead of master ? Cheers!

@OJ
Copy link
Owner

OJ commented Jan 15, 2016

FYI, if you didn't intend for the file stuff to appear in this PR, it's because your PR is from master, and all your master changes appear here ;)

@OJ
Copy link
Owner

OJ commented Jan 15, 2016

@andrewaeva Please see here: https://github.com/OJ/gobuster/compare/wildcard-support?expand=1

I've rejigged the implementation so that it fits better within the style of the source. Can you please try it out and let me know if it works for you. Thanks.

@OJ
Copy link
Owner

OJ commented Jan 15, 2016

I've added the changes to master. Thanks. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants