olsr 0.9.0.3 doesn't build with the musl C library #6
Labels
Comments
|
olsrd is not prepared for parallel compilation, first try building it that way. |
|
Thanks for the feedback. Building with make -j1 doesn't change anything to the musl compatibility issue: |
|
that is strange since I know Basti was able to compile it some time ago. For now I don't see a problem with olsrd, unless you can point it out a bit more clearly than a long list of include file errors from files outside of olsrd. |
|
Well, the build problem is due to olsrd mixing kernel headers and userspace headers, see http://wiki.musl-libc.org/wiki/FAQ#Q:_why_am_i_getting_.22error:_redefinition_of_struct_ethhdr.2Ftcphdr.2Fetc.22_.3F for details. |
|
can you please try with musl-git from today? |
|
You're thinking about http://git.musl-libc.org/cgit/musl/commit/?id=04983f2272382af92eb8f8838964ff944fbb8258 ? |
|
tpetazzoni: yes |
|
This musl commit is not sufficient by itself. Indeed, this musl commit only has an effect if the patch at http://www.openwall.com/lists/musl/2016/11/11/1 is applied to the kernel headers. So even when this patch gets applied to the kernel, we'll have issues for a long time, until everyone moves to a recent enough kernel to be able to use recent kernel headers. |
|
i understand your issue, but what seems strange: you are building with musl but using an older kernel? i only compile olsrd-git with LEDE/OpenWrt - and the only thing i must patch away is the 'pud' and the 'pgraph'-plugin (because of missing gpsd-headers) but it compiles and runs fine... |
|
tpetazzoni is right and it can easily reproduced with 'buildroot' from |
|
See, is this still an issue for us to fix? |
|
@fhuberts this is still an issue (but it works on OpenWRT/LEDE) |
|
if it works there then I consider this 'not an issue' |
|
it is not an important issue, but it is an issue which should be left open. something for a long winter-evening. |
|
Then I suggest someone with an active interest in compiling with musl should fix this. Not really my itch to scratch. |
This was referenced Oct 18, 2017
|
Hello all, Please, I would like to build OLSR and modify it for my research. I have gone through this forum and I need as much help as I can get. If possible, we can collaborate together and write an article |
|
FYI, OLSR is building fine with musl under those two conditions:
|
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this issue
Jan 12, 2020
olsr has been disabled on musl three years ago by commit 4bca88c. Comments in OLSR/olsrd#6 suggest that the issue was due to olsr mixing kernel and userspace headers. This issue is still open. However, nowadays olsr builds fine on musl under those two conditions: - musl >= 1.1.16 (i.e. with http://git.musl-libc.org/cgit/musl/commit/?id=04983f2272382af92eb8f8838964ff944fbb8258) - kernels >= 4.15 (i.e. with torvalds/linux@c0bace7) So enable it back on musl with kernels >= 4.15. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
|
I'm closing this issue as @fhuberts provided some fixes and positive advice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As explained in the title, olsr in its version 0.9.0.3 doesn't build with the musl C library, see:
The text was updated successfully, but these errors were encountered: