Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

initial commit, created via dp project generation tool #1

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

p-patel
Copy link
Contributor

@p-patel p-patel commented Feb 14, 2022

What

Created via dp project generation tool

How to review

Check passing tests and correct service configuration inc. port

Who can review

Anyone

@p-patel p-patel marked this pull request as ready for review February 17, 2022 13:41
@cookel2 cookel2 self-requested a review February 18, 2022 14:45
Copy link

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of tweaks needed

module github.com/ONSdigital/dp-maps-api

go 1.17

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run 'go mod tidy' then it will add something like this:

Suggested change
require (
github.com/ONSdigital/dp-component-test v0.6.5
github.com/ONSdigital/dp-healthcheck v1.2.3
github.com/ONSdigital/dp-net v1.4.1
github.com/ONSdigital/log.go/v2 v2.1.0
github.com/cucumber/godog v0.10.0
github.com/gorilla/mux v1.8.0
github.com/kelseyhightower/envconfig v1.4.0
github.com/pkg/errors v0.9.1
github.com/smartystreets/goconvey v1.7.2
github.com/stretchr/testify v1.7.0
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

swagger.yaml Outdated
last_failure:
type: string
description: "The last failed health check date and time of the external service"
example: "2019-09-22T11:48:51.0000001Z"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs a new line at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@p-patel p-patel force-pushed the feature/boilerplate-generation branch from 7fca485 to e23bbe4 Compare February 18, 2022 17:25
@cookel2 cookel2 self-requested a review February 21, 2022 09:14
Copy link

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@p-patel p-patel merged commit c7f805b into develop Feb 21, 2022
@p-patel p-patel deleted the feature/boilerplate-generation branch February 21, 2022 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants