-
Notifications
You must be signed in to change notification settings - Fork 0
initial commit, created via dp project generation tool #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of tweaks needed
module github.com/ONSdigital/dp-maps-api | ||
|
||
go 1.17 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run 'go mod tidy' then it will add something like this:
require ( | |
github.com/ONSdigital/dp-component-test v0.6.5 | |
github.com/ONSdigital/dp-healthcheck v1.2.3 | |
github.com/ONSdigital/dp-net v1.4.1 | |
github.com/ONSdigital/log.go/v2 v2.1.0 | |
github.com/cucumber/godog v0.10.0 | |
github.com/gorilla/mux v1.8.0 | |
github.com/kelseyhightower/envconfig v1.4.0 | |
github.com/pkg/errors v0.9.1 | |
github.com/smartystreets/goconvey v1.7.2 | |
github.com/stretchr/testify v1.7.0 | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
swagger.yaml
Outdated
last_failure: | ||
type: string | ||
description: "The last failed health check date and time of the external service" | ||
example: "2019-09-22T11:48:51.0000001Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs a new line at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
7fca485
to
e23bbe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
What
Created via dp project generation tool
How to review
Check passing tests and correct service configuration inc. port
Who can review
Anyone