Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copied DrainBody function from go-ns to dp-net/http #11

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Copied DrainBody function from go-ns to dp-net/http #11

merged 2 commits into from
Aug 14, 2020

Conversation

DavidSubiros
Copy link
Contributor

@DavidSubiros DavidSubiros commented Aug 13, 2020 •
edited
Loading

What

Moved DrainBody function from go-ns to dp-net/http. This function is used by dp-api-router

How to review

  • Make sure code changes make sense (function copied from go-ns/request)
    • Note: this was added to http package - if we added it to request package, we would reintroduce the cyclic dependency with log.go
  • Unit tests should pass

Who can review

Anyone

CarlHembrough
CarlHembrough suggested changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@CarlHembrough CarlHembrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bring the unit tests across to this package also?

https://github.com/ONSdigital/go-ns/blob/48333fb537367021dc98a30ec3288fbcf5625145/request/request_test.go

@DavidSubiros DavidSubiros merged commit d5ebc2c into master Aug 14, 2020
@DavidSubiros DavidSubiros deleted the feature/add-drain-body branch August 14, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlHembrough CarlHembrough CarlHembrough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidSubiros @CarlHembrough