New controller middleware handler #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandwal
force-pushed
the
feature/frontend-controller-middleware
branch
from
a608eaf
to
3eee78c
Compare
- GetCollectionID function now exists - getCollectionIDFromCookie function now exists - GetFlorenceToken function now exported - Update tests to reflect actual behaviour
dandwal
force-pushed
the
feature/frontend-controller-middleware
branch
from
9199d1d
to
4debb19
Compare
DavidSubiros
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A new middleware handler has been added for frontend controller usage.
This middleware ensures that language is always set (defaults if not set) and will log warnings if Florence Access Tokens or Collection IDs are not present.
How to review
This can be seen working here: ONSdigital/dp-frontend-homepage-controller#43 on the homepage controller. Note that the PR is failing due to the need of this dp-net PR needing to be pulled into develep, which will happen once this is approved.
Check the tests give full coverage to new code. Ensure that this won't break anything
How to use
Who can review
Anyone who is comfortable with middleware and GO