Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed READMEs, removed error types and duplicated function #2

Merged
merged 1 commit into from
May 11, 2020
Merged

fixed READMEs, removed error types and duplicated function #2

merged 1 commit into from
May 11, 2020

Conversation

DavidSubiros
Copy link
Contributor

What

  • Removed unused error types
  • Fixed typos and READMEs
  • Removed duplicated Close function in server.go (kept Shutdown)

How to review

  • This PR addresses @eldeal review of develop branch before merging it to master.
  • Make sure the unit tests pass

Who can review

Anyone

@DavidSubiros DavidSubiros merged commit 04a7f64 into develop May 11, 2020
@DavidSubiros DavidSubiros deleted the feature/fix-readmes-and-server branch May 11, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldeal eldeal eldeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidSubiros @eldeal