Decrease default retries to fail faster #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default retries limit was 10 which is very high for a library used for internal retires. This is basically causing friendly fire DDoS issues an resulting in a very poor user experience as it takes ages to fail. Reducing the default means that we should fail faster, but still allows for a small failure tolerance.
jondewijones
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The default retries limit was 10 which is very high for a library used
for internal retires. This is basically causing friendly fire DDoS
issues an resulting in a very poor user experience as it takes ages to
fail. Reducing the default means that we should fail faster, but still
allows for a small failure tolerance.
Who can review
Anyone but me.