Used ContextKey type from go-ns, to prevent having incompatible types #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use ContextKey type from go-ns, to prevent incompatible types in code that uses this library and other libraries that use the go-ns common ContextKey type. This is important because Context accepts
interface{}
type, so we would not be able to detect mismatches at compile time.Although this PR looks like a step back, it is created in order to facilitate the transition from go-ns to dp-net. Once everything uses dp-net (and nothing refers to the go-ns ContextKey type directly), we can move the ContextKey type definition to this library, and everything will be consistent.
How to review
Who can review
Anyone.