Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/4.1.0 #586

Closed
wants to merge 33 commits into from
Closed

Release/4.1.0 #586

wants to merge 33 commits into from

Conversation

andreea-pasare
Copy link
Collaborator

eAccess module implementation; ePO maintenance tasks.

Copy link
Contributor

@cristianvasquez cristianvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

After a quick inspection I realize that there are several elements missing in the RDF that appear in the conceptual model. I've created a diagram of what I expected to included to be exported as the eAccess module

Expected

However, I don't see all of it in the RDF, for example some relations are missing. I could be wrong, but I believe this is due to an Model2OWL exporting issue. When I inspect the provided XMI into enterprise architect I see it misses the elements from other modules, for example Notice is missing (from core).

Exported2
Exported1

The export is losing information, in particular relations are not honored. What is Model2OWL using as input?

See for example the relations from the conceptual model that contains all modules:

Relations1

And the one from the XMI

Relations2

The latter contains less relations, which are not exported in the corresponding SHACL shapes.

We need to find a way to export all elements. In the meantime for 4.1.0 we can discuss a workaround, which could to

  • prepare a conceptual model with one module with all the classes just for this export
    or
  • just write the RDF by hand. (which would be acceptable as this is a small module)
    or
  • export somehow the whole XML, then filter out the triples to only have the ones relevant to eAccess module

Also there are several elements from other vocabularies being exported. We can discuss this separately in Model2OWL. We need to export the whole model and publish only what is related to epo-acc (a subset of the whole RDF graph, only triples that touch epo-acc)

@andreea-pasare
Copy link
Collaborator Author

Hi,

The elements that are coming from ePO core do not appear in the eAccess core layer RDF file because we import the core layer of the ePO core in the owl:import tag.

The input for model2owl is the xml file for the specific module, eAccess in this case.

cristianvasquez and others added 4 commits March 21, 2024 11:09
# Conflicts:
#	analysis_and_design/conceptual_model/ePO_CM.eap
#	glossary/eAccess_glossary.html
#	glossary/ePO_combined_glossary.html
#	glossary/ePO_core_glossary.html
#	implementation/eAccess/conventions_report/eAccess_convention_report.html
#	implementation/eAccess/model2owl-config/config-parameters.xsl
#	implementation/eAccess/owl_ontology/eAccess.rdf
#	implementation/eAccess/owl_ontology/eAccess.ttl
#	implementation/eAccess/owl_ontology/eAccess_restrictions.rdf
#	implementation/eAccess/owl_ontology/eAccess_restrictions.ttl
#	implementation/eAccess/shacl_shapes/eAccess_shapes.rdf
#	implementation/eAccess/shacl_shapes/eAccess_shapes.ttl
#	implementation/eAccess/xmi_conceptual_model/eAccess.xml
#	implementation/eCatalogue/conventions_report/eCatalogue_convention_report.html
#	implementation/eCatalogue/model2owl-config/config-parameters.xsl
#	implementation/eCatalogue/owl_ontology/eCatalogue.rdf
#	implementation/eCatalogue/owl_ontology/eCatalogue.ttl
#	implementation/eCatalogue/owl_ontology/eCatalogue_restrictions.rdf
#	implementation/eCatalogue/owl_ontology/eCatalogue_restrictions.ttl
#	implementation/eCatalogue/shacl_shapes/eCatalogue_shapes.rdf
#	implementation/eCatalogue/shacl_shapes/eCatalogue_shapes.ttl
#	implementation/eCatalogue/xmi_conceptual_model/eCatalogue.xml
#	implementation/eContract/conventions_report/eContract_convention_report.html
#	implementation/eContract/model2owl-config/config-parameters.xsl
#	implementation/eContract/owl_ontology/eContract.rdf
#	implementation/eContract/owl_ontology/eContract.ttl
#	implementation/eContract/owl_ontology/eContract_restrictions.rdf
#	implementation/eContract/owl_ontology/eContract_restrictions.ttl
#	implementation/eContract/shacl_shapes/eContract_shapes.rdf
#	implementation/eContract/shacl_shapes/eContract_shapes.ttl
#	implementation/eContract/xmi_conceptual_model/eContract.xml
#	implementation/eFulfilment/conventions_report/eFulfilment_convention_report.html
#	implementation/eFulfilment/model2owl-config/config-parameters.xsl
#	implementation/eFulfilment/owl_ontology/eFulfilment.rdf
#	implementation/eFulfilment/owl_ontology/eFulfilment.ttl
#	implementation/eFulfilment/owl_ontology/eFulfilment_restrictions.rdf
#	implementation/eFulfilment/owl_ontology/eFulfilment_restrictions.ttl
#	implementation/eFulfilment/shacl_shapes/eFulfilment_shapes.rdf
#	implementation/eFulfilment/shacl_shapes/eFulfilment_shapes.ttl
#	implementation/eFulfilment/xmi_conceptual_model/eFulfilment.xml
#	implementation/eNotice/conventions_report/eNotice_convention_report.html
#	implementation/eNotice/model2owl-config/config-parameters.xsl
#	implementation/eNotice/owl_ontology/eNotice.rdf
#	implementation/eNotice/owl_ontology/eNotice.ttl
#	implementation/eNotice/owl_ontology/eNotice_restrictions.rdf
#	implementation/eNotice/owl_ontology/eNotice_restrictions.ttl
#	implementation/eNotice/shacl_shapes/eNotice_shapes.rdf
#	implementation/eNotice/shacl_shapes/eNotice_shapes.ttl
#	implementation/eNotice/xmi_conceptual_model/eNotice.xml
#	implementation/eOrdering/conventions_report/eOrdering_convention_report.html
#	implementation/eOrdering/model2owl-config/config-parameters.xsl
#	implementation/eOrdering/owl_ontology/eOrdering.rdf
#	implementation/eOrdering/owl_ontology/eOrdering.ttl
#	implementation/eOrdering/owl_ontology/eOrdering_restrictions.rdf
#	implementation/eOrdering/owl_ontology/eOrdering_restrictions.ttl
#	implementation/eOrdering/shacl_shapes/eOrdering_shapes.rdf
#	implementation/eOrdering/shacl_shapes/eOrdering_shapes.ttl
#	implementation/eOrdering/xmi_conceptual_model/eOrdering.xml
#	implementation/ePO_core/conventions_report/ePO_core_convention_report.html
#	implementation/ePO_core/model2owl-config/config-parameters.xsl
#	implementation/ePO_core/owl_ontology/ePO_core.rdf
#	implementation/ePO_core/owl_ontology/ePO_core.ttl
#	implementation/ePO_core/owl_ontology/ePO_core_restrictions.rdf
#	implementation/ePO_core/owl_ontology/ePO_core_restrictions.ttl
#	implementation/ePO_core/shacl_shapes/ePO_core_shapes.rdf
#	implementation/ePO_core/shacl_shapes/ePO_core_shapes.ttl
#	implementation/ePO_core/xmi_conceptual_model/ePO_core.xml
…dated owl:priorVersion to 4.0.2 in eAccess module
@cristianvasquez
Copy link
Contributor

cristianvasquez commented Mar 21, 2024

@andreea-pasare @AchillesDougalis I went through the produced RDF, but we need to discuss how we deal with the unwanted elements exported by Model2Owl.

I bundled the contents of all RDF files for e-access here, it contains elements mostly from eli.

To illustrate what I mean, I wrote by hand here what would be my expectation, based on the diagram I posted before.

@cristianvasquez cristianvasquez deleted the release/4.1.0 branch March 22, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants