Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate .NET framework 4.6.2 support, sync with samples repo #2165

Merged
merged 5 commits into from
May 31, 2023

Conversation

mregen
Copy link
Contributor

@mregen mregen commented May 30, 2023

Proposed changes

  • Deprecate support for Nuget package support of .NET Framework 4.6.2
  • Bump sample applications to 4.8
  • update some copyright headers / supporting files (editorconfig etc.)
  • fix a few warnings
  • fix an issue with SessionReconnectHandler, in certain combination of reconnect period and exponential backoff the .NET sample app never reconnected.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mregen mregen marked this pull request as draft May 30, 2023 09:12
@mregen mregen marked this pull request as ready for review May 31, 2023 12:29
Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok

@mregen mregen self-assigned this May 31, 2023
@mregen mregen added this to the 1.4.372 service update milestone May 31, 2023
@mregen mregen merged commit 043a56c into master May 31, 2023
@mregen mregen deleted the housekeeping branch May 31, 2023 16:54
TimJoehnk pushed a commit to TimJoehnk/UA-.NETStandard that referenced this pull request Aug 4, 2023
…undation#2165)

- Deprecate support for Nuget package support of .NET Framework 4.6.2
- Bump sample applications to 4.8
- update some copyright headers / supporting files (editorconfig etc.)
- fix a few warnings
- fix an issue with `SessionReconnectHandler`, in certain combination of reconnect period and exponential backoff the .NET sample app never reconnected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate support for .NET Framework 4.6.2, instead only support .NET Framework 4.8
2 participants