-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client] Fix UserIdentity for CertificateIdentifer & add parameter for console reference client to specify UserCertificate #2624
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2624 +/- ##
==========================================
- Coverage 54.66% 47.94% -6.72%
==========================================
Files 343 328 -15
Lines 65218 63782 -1436
Branches 13354 13056 -298
==========================================
- Hits 35653 30582 -5071
- Misses 25685 29722 +4037
+ Partials 3880 3478 -402 ☔ View full report in Codecov by Sentry. |
|
||
#### Certificate | ||
Place your user certificate in the TrustedUserCertificatesStore (the path can be found in the client configuration XML). Make shure to include an accessible private key with the certificate. | ||
Specify console parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: sure
CertificateIdentifier userCertificateIdentifier = null; | ||
|
||
// get user certificate with matching thumbprint | ||
X509Certificate2Collection userCertifiactesWithMatchingThumbprint = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Certificate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great sample and bug fix.
Proposed changes
-uc Thumbprint of a user certifiate located in the TrustedUserCertificatesStore
-ucp Password of the private key of the user certificate
Related Issues
Types of changes
Checklist
Further comments
Tested with a Certificate created with XCA.
Public Key was exported as DER
Private key was exported as PEM without PW and also as PFX with a password.
Both work as a user identity token.