Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added: handle multiple right hand sides in umfpack solve #387

Merged
merged 1 commit into from
Oct 25, 2019
Merged

added: handle multiple right hand sides in umfpack solve #387

merged 1 commit into from
Oct 25, 2019

Conversation

akva2
Copy link
Member

@akva2 akva2 commented Oct 23, 2019 •
edited
Loading

Fixes #386

kmokstad
kmokstad approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@kmokstad kmokstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested it, and seems to work fine.

A question though: The coefficient matrix is now triangulated for each RHS, or does umfpack have an internal flag that somehow enables it to reuse the last factorization, if present? If not, there is an optimization potential here.

@akva2
Copy link
Member Author

akva2 commented Oct 25, 2019

umfpack solve is divided in 3 steps;
symbolic factorization, numeric factorization, solution. we only loop the solution step - the factorizations are not repeated.

@akva2 akva2 merged commit 58bbc1f into OPM:master Oct 25, 2019
@akva2 akva2 deleted the multiple_umfpack branch October 25, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmokstad kmokstad kmokstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UMFPACK mode does not work with multiple right-hand-sides
2 participants
@akva2 @kmokstad