Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Completions: Continue exporting other completions if one has a unit mismatch. #2881

Closed
lindkvis opened this issue May 9, 2018 · 0 comments
Closed

Export Completions: Continue exporting other completions if one has a unit mismatch. #2881

lindkvis opened this issue May 9, 2018 · 0 comments
Assignees
@lindkvis
Labels
Enhancement An addition that can be observed by the user
Milestone
Sprint 9 - HydraFrac

Comments

@lindkvis
Copy link
Contributor

lindkvis commented May 9, 2018

Instead of aborting completely, we should report an error and continue with other completions. This also allows better regression testing behaviour.
@lindkvis lindkvis added the Enhancement An addition that can be observed by the user label May 9, 2018
@lindkvis lindkvis added this to the Sprint 9 - HydraFrac milestone May 9, 2018
@lindkvis lindkvis self-assigned this May 9, 2018
@lindkvis lindkvis closed this as completed May 9, 2018
lindkvis added a commit that referenced this issue May 9, 2018
@lindkvis
#2881 Continue exporting other completions if one has a unit mismatch.
b9cbd7c 
* Report an error and continue rather than abort.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindkvis lindkvis

Labels
Enhancement An addition that can be observed by the user
Projects
None yet
Milestone
Sprint 9 - HydraFrac
Development

No branches or pull requests
1 participant
@lindkvis