Restore UDQ Update Status on Simulation Restart #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
bska
force-pushed
the
fix-udq-rst-update-status
branch
from
95ede51
to
f3b2364
Compare
Thank you for testing. I'll mark this as ready for review now. |
bska
force-pushed
the
fix-udq-rst-update-status
branch
from
f3b2364
to
f07eea0
Compare
|
jenkins build this please |
bska
force-pushed
the
fix-udq-rst-update-status
branch
3 times, most recently
from
8b7e056
to
cd97109
Compare
The current master sources implicitly assume that all UDQs loaded from the restart file have an 'UPDATE' status of 'ON'. This commit allows the restart code to inspect the actual update status and to use that status in the UDQ configuration object when restarting the simulation run.
bska
force-pushed
the
fix-udq-rst-update-status
branch
from
cd97109
to
a5619fe
Compare
blattms
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current master sources implicitly assume that all UDQs loaded from the restart file have an
UPDATEstatus ofON. This commit allows the restart code to inspect the actual update status and to use that status in the UDQ configuration object when restarting the simulation run.Closes #3808