Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed EclipseGridParser::saveEGRID() to take globalCells input #286

Merged
merged 7 commits into from
Jul 30, 2013

Conversation

joakim-hove
Copy link
Member

The EclipseGridParser::saveEGRID() takes an input argument (const int * globalCell) which is used ta map out ACTNUM. This is to ensure that the saved ACTNUM field is correct with respect to cells which have been deactivated by opm-core.

Observe that the methods saveINIT() and saveEGRID_INIT() are not really functional after this PR; but they have no callers.

This PR is a start of a fix to: OPM/opm-upscaling#69, a similar PR will come for opm-porsol.

@bska
Copy link
Member

bska commented Jul 30, 2013

@joakim-hove 👍 This is great! Thanks a lot. I'll merge this once the consumers in OPM-Porsol and OPM-Upscaling are updated accordingly so as not to break the build.

I just have one minor nit if you don't mind. Would you mind applying the same

static_cast<void>()

trick to the new parameters (i.e., num_cells and global_cell) of EclipseGridParser::saveEGRID() in the ! HAVE_ERT case, too? I'd rather not introduce additional "unused parameter" warnings in OPM-Core.

@bska
Copy link
Member

bska commented Jul 30, 2013

Oh, one more thing. Is the filename parameter of GridManager::saveEGRID() supposed to be unused or should the implementation rather be something along the lines of

void GridManager::saveEGRID(const std::string& filename , const Opm::EclipseGridParser& deck) {
    deck.saveEGRID( filename , ug_->number_of_cells , ug_->global_cell );
}

@bska
Copy link
Member

bska commented Jul 30, 2013

Thanks a lot! All tests pass in all modules so I'll merge this into master. Thanks again for taking on this task.

bska added a commit that referenced this pull request Jul 30, 2013
…ing-cells

Changed EclipseGridParser::saveEGRID() to take globalCells input
@bska bska merged commit 0023e50 into OPM:master Jul 30, 2013
@joakim-hove joakim-hove deleted the save-eclgrid-after-deactivating-cells branch August 12, 2015 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants