Publicly depend on version of dune-grid #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface of the class PersistentContainer changed between DUNE 2.2 and DUNE 2.3 in an incompatible way, so we need to present different versions of the class depending on the version of DUNE linked with. This changeset adds the version variables for dune-grid to the list of publicly necessary #defines that must go into using dune-cornerpoint. Notice that this will cause the definition of DUNE_GRID_VERSION_XXX to be added to the flags list of dune-cornerpoint. This can be seen as either a bug or a feature. If you try to link first dune-cornerpoint to one version and then to another version of DUNE later, there is a very good chance that you'll end up with problems anyway.
|
This looks good and is (probably) uncontroversial. I'll merge it into master. |
bska
added a commit
that referenced
this pull request
Aug 14, 2013
Publicly depend on version of dune-grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface of the class PersistentContainer changed between DUNE
2.2 and DUNE 2.3 in an incompatible way, so we need to present
different versions of the class depending on the version of DUNE linked
with. This changeset adds the version variables for dune-grid to the
list of publicly necessary #defines that must go into using
dune-cornerpoint.
Notice that this will cause the definition of DUNE_GRID_VERSION_XXX
to be added to the flags list of dune-cornerpoint. This can be seen as
either a bug or a feature. If you try to link first dune-cornerpoint to
one version and then to another version of DUNE later, there is a very
good chance that you'll end up with problems anyway.