Make opm-core compilable in C++0x mode on Ubuntu Precise #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| // macro to insert const_cast to get a round bug in GCC 4.6.3 where it | ||
| // suddenly believes that this is a const pointer, although we are not in |
There was a problem hiding this comment.
Would you mind highlighting the word 'this' in the above (e.g., ...believes that "this" is a...)? I think that will assist the would-be reader who might otherwise have a hard time interpreting the sentence in isolation.
|
Have you been able to track down a bug number in GCC's issue tracker that describes this issue? |
It complains about not finding a match for the pair<> template class, because the first parameter (this) is allegedly const. However, this isn't a const method, so I suspect it is a compiler bug. In order to move on, I slap on a harmless cast which will make this particular compiler happy, and which should have no effects elsewhere, but put it in a #if..#else..#endif macro to avoid warnings on others; hopefully this also makes it easier to spot and remove in the future.
|
Thanks. I'll merge the change. |
bska
added a commit
that referenced
this pull request
Oct 24, 2012
Make opm-core compilable in C++0x mode on Ubuntu Precise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.