This completes the transition of identifying overlap cells with copy … #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indices in dune-istl. It was needed for the parallel AMG to behave as expected when agglomerating data to fewer processes. In this case the overlap in the dune-grid sense has to marked as copy in the dune-istl index sets. This was already done for the index sets, but the manually crafted remote index list unsed in CpGrid did not reflect the change and still marked cells not interrior as overlap and not copy. While this was not a problem for the communication within the grid interface, it broke the communication within dune-istl. The latter is used in opm-autodiff and opm-core and there is poses a serious problem. This commit fixes the setup of the remote index lists.
|
This is also a bugfix and it might make sense to included in the release. |
|
Thanks for the patch! I'll merge. |
atgeirr
added a commit
that referenced
this pull request
Oct 28, 2015
This completes the transition of identifying overlap cells with copy …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…indices in dune-istl.
It was needed for the parallel AMG to behave as expected when
agglomerating data to fewer processes. In this case the overlap in the
dune-grid sense has to marked as copy in the dune-istl index sets.
This was already done for the index sets, but the manually crafted
remote index list unsed in CpGrid did not reflect the change and
still marked cells not interrior as overlap and not copy. While this
was not a problem for the communication within the grid interface, it
broke the communication within dune-istl. The latter is used in
opm-autodiff and opm-core and there is poses a serious problem.
This commit fixes the setup of the remote index lists.