Cp to cv #282
Merged
Cp to cv #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstant pressure this implies that the internal energy instead of the enthalpy is specified by the fluid PVT classes.
This was referenced Feb 1, 2018
Closed
|
I do not understand anything - maybe everything started with me merging the wrong PR in opm-material? This is at least what I merged yesterday - but maybe I should have merged another PR?? |
|
the argument its quite technical and it might be that this is handled inconsistently by ECL itself, but this one and the opm-parser PR should not affect any downstream masters, because there are currently no non-isothermal simulators yet.
merging this was the correct thing to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the downstream PR for OPM/opm-parser#1200.