Added script to fix ignored keywords #148
Conversation
There was a problem hiding this comment.
This looks really cool. Thanks a lot.
@lisajulia can you have a look at the code and merge, please?
| if match := re.match(r"""(\s*<text:p\s+.*?>)(.*?)(</text:p>.*$)""", line, re.DOTALL): | ||
| start, txt, end = match.groups() | ||
| # Remove span tags from txt | ||
| txt = re.sub(r"""<text:span .*?>(.*?)</text:span>""", r"\1", txt) | ||
| txt = re.sub(r"""<text:span>(.*?)</text:span>""", r"\1", txt) | ||
| if "is ignored by OPM Flow and has no effect on the simulation" in txt: | ||
| logging.info(f"Found ignored match in {file}:{line_no}.") | ||
| txt = self.replace_ignored(txt, critical) | ||
| line = start + txt + end | ||
| changed = True |
There was a problem hiding this comment.
Just one question. There is ugly case with ... simulatio</text:span><text:span text:style-name="T2789">n.</text:span>. That is probably not covered and needs to be done manually. I guess that is ok, though as we cannot anticipate these kind of formatting things.
There was a problem hiding this comment.
That is probably not covered and needs to be done manually.
@blattms If you mean the case that there is no space between closing and starting tag: </text:span><text:span>, it should also work. I tested it now.
| @click.command() | ||
| @ClickOptions.maindir(required=False) | ||
| def fix_ignored(maindir: str | ||
| ) -> None: |
There was a problem hiding this comment.
Is the line break here intentional?
There was a problem hiding this comment.
No they are not :) Thanks, for the comment, I will fix this. (I have problems pushing to this branch for some reason, so need to fix this problem first)
There was a problem hiding this comment.
I have problems pushing to this branch for some reason, so need to fix this problem first
I have updated the PR in a new PR, see #149.
|
Replaced by #150. |
See #52 for background.