fixing running with CO2Store + water + gas + AquiferCarterTracy #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
GitPaean
commented
Apr 3, 2023
| Scalar rsw = 0.; | ||
| waterViscosity = FluidSystem::waterPvt().viscosity(pvtRegionIdx(), temp, press, rsw, salt); | ||
| } else { | ||
| OPM_THROW(std::runtime_error, "water or oil phase is needed to run CO2Store."); |
There was a problem hiding this comment.
I tried to do some sanity checking in the constructor functions for AquiferInterface, but somehow FluidSystem::phaseIsActive() does not work there. Not sure why.
|
It needs some update from the opm-common. |
|
jenkins build this please |
|
Thanks. The code looks reasonable and it fixes the problem. |
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.