Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unsupported keywords from test model data decks. #854

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Removing unsupported keywords from test model data decks. #854

merged 1 commit into from
Nov 14, 2022

Conversation

tskille
Copy link
Contributor

@tskille tskille commented Nov 13, 2022 •
edited
Loading

Removing keywords that are not supported by Flow. Since these keywords are unsupported, this PR will not impact simulation results. Hence no update of reference solutions should be necessary. The following keywords are removed from test models.

GRIDUNINT, OPTIONS, PIMULTAB, RESVNUM, COORDSYS and GCONTOL, WPITAB, GECON and GRUPNET.

@tskille
Copy link
Contributor Author

tskille commented Nov 13, 2022

This PR is a preparation for a PR in opm-simulators that will make the majority of unsupported keywords critical.

@bska
Copy link
Member

bska commented Nov 13, 2022

jenkins build this please

bska
bska reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine in general, but I'd like to ask if there's a plan to restore these keywords, especially GECON and GRUPNET, if/when the simulator gains support for them.

@tskille
Removing unsupported keywords from test model data decks.
2808d99 
Removing keywords that are not supported by Flow. Since these keywords are unsupported, this PR will not impact simulation results. Hence no update of reference solutions should be necessary. The following keywords are removed from test models.

GRIDUNINT, OPTIONS, PIMULTAB, RESVNUM, COORDSYS and GCONTOL, WPITABi, GECON and GRUPNET
@tskille
Copy link
Contributor Author

tskille commented Nov 14, 2022 •
edited by bska
Loading

I have pushed an update where I have used used -- to mark GRUPNET and GECON keywords as comments. This way the keywords are visible and it will be really easy to take these in again if/when support is gain in Flow.

@bska
Copy link
Member

bska commented Nov 14, 2022

I have pushed an update where I have used used -- to mark GRUPNET and GECON keywords as comments.

Very good. This looks fine to me now and I'll just run a final build check. Assuming the build check is green I'll merge this into the master branch.

@bska
Copy link
Member

bska commented Nov 14, 2022

jenkins build this please

1 similar comment
@bska
Copy link
Member

bska commented Nov 14, 2022

jenkins build this please

bska
bska approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates. I'll merge this into the master branch.

@bska bska merged commit dcfdfb6 into OPM:master Nov 14, 2022
@OPMUSER OPMUSER mentioned this pull request Nov 29, 2022
Closed
@bska bska mentioned this pull request Dec 7, 2022
Merged
@tskille tskille deleted the supported_keyw branch March 30, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bska bska bska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tskille @bska