apollostage fixes for mobile menu and many more #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review at this time. |
|
Now really ready for code review by upstream. ❖ All SVGs and Fonts referenced by the apollostage stylesheets, are now pulled from /public/static, meaning they can be easily copied to a production edge server (together with the compiled CSS). In other words, google fonts are now local. ❖ Full changelog is in _base.scss. Hope you'll like how all colors are abstracted/tokenized. Further improvement may be possible by importing the colors from _variable.scss to https://palettte.app/ ~~ enjoy! |
…at would require special handling to fix.
…at would require special handling to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to submit changes to apollostage stylesheets back to to Gazelle.
Please note the _variables.scss contains URLs for SVG files that need to be adjusted (both in your repo, and in deployment).