Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thermal cracking #102

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Thermal cracking #102

merged 8 commits into from
Jun 27, 2024

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented May 30, 2024 •
edited
Loading

Extends #93

@streeve streeve requested a review from pabloseleson May 30, 2024 13:30
@streeve streeve self-assigned this May 30, 2024
@streeve streeve marked this pull request as draft May 30, 2024 13:30
@streeve streeve force-pushed the thermal_cracking branch 5 times, most recently from d4dd8bf to 867f7ac Compare June 14, 2024 17:40
@streeve streeve marked this pull request as ready for review June 14, 2024 17:48
@streeve streeve added the example New example problem label Jun 14, 2024
@pabloseleson
Copy link
Collaborator

ThermalCracks-cropped

Initial simulation of thermal crack.

pabloseleson
pabloseleson approved these changes Jun 24, 2024
View reviewed changes
examples/thermomechanics/inputs/thermal_crack.json Outdated Show resolved Hide resolved
examples/thermomechanics/inputs/thermal_crack.json Outdated Show resolved Hide resolved
src/force/CabanaPD_ForceModels_PMB.hpp Show resolved Hide resolved
streeve
streeve commented Jun 24, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pabloseleson
Copy link
Collaborator

With the current problem settings, the simulation seems to take about ~10h on my desktop and ~20h on my laptop.

@pabloseleson
Copy link
Collaborator

Current output:
Untitled

@pabloseleson
Copy link
Collaborator

Besides the length of the simulation, is this ready to be merged?

@streeve
Copy link
Collaborator Author

streeve commented Jun 27, 2024

With the current problem settings, the simulation seems to take about ~10h on my desktop and ~20h on my laptop.

This is extremely slow compared to the other problems - can we not reduce the resolution at all? We can merge as is and change later I suppose

@pabloseleson
Copy link
Collaborator

With the current problem settings, the simulation seems to take about ~10h on my desktop and ~20h on my laptop.

This is extremely slow compared to the other problems - can we not reduce the resolution at all? We can merge as is and change later I suppose

Yes, we can probably merge and adapt the example resolution afterwards.

@streeve streeve mentioned this pull request Jun 27, 2024
Open
@streeve streeve merged commit f1485b2 into ORNL:main Jun 27, 2024
14 checks passed
@streeve streeve deleted the thermal_cracking branch June 27, 2024 18:22
@streeve streeve mentioned this pull request Jul 8, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloseleson pabloseleson pabloseleson approved these changes

Assignees

@streeve streeve

Labels
example New example problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@streeve @pabloseleson