Rabbitmq to Devel #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaSBrown
added this to the Implement Scientific use Case by e-science ~ February 2023 milestone
JoshuaSBrown
commented
Jan 11, 2023
| self._logger = logger | ||
| self._plugins_message_template_generators = PluginsMessageTemplateEngine(logger) | ||
| self._plugins_message_validators = PluginsMessageValidator(logger) | ||
| self._plugins = plugins |
There was a problem hiding this comment.
This change is incorrect, the template generator and message validator were separated from the plugins object intentionally. The MessageFactory only needs to be able to generate templates and validate them, it doesn't need to run the plugins which was the reason for the change. Hopefully, that makes sense.
There was a problem hiding this comment.
Though I don't know if the gitdiff is working correctly here or not still, so this is just a guess. Hopefully, our patch command isn't messing with us here.
…th Josh's abstractions.
|
@par-hermes format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses several open tasks. Including the switch to rabbitMQ.