Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting passenger_pool_idle_time #1209

Merged
merged 4 commits into from
Jun 10, 2021
Merged

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Jun 9, 2021

Fixes #1208

@johrstrom
Copy link
Contributor

Thanks! needs to be added to the example too though.

@treydock
Copy link
Contributor Author

treydock commented Jun 9, 2021

I updated the example config, also made sure to mention that setting false can avoid putting this in the NGINX configs.

@treydock
Copy link
Contributor Author

treydock commented Jun 9, 2021

I missed something, which e2e tests picked up. Running locally I get this when starting PUN:

Error -- undefined local variable or method `passenger_pool_idle_time' for #<NginxStage::PunConfigGenerator:0x0000561c34aa7520>
Did you mean?  passenger_root
Run 'nginx_stage --help' to see a full list of available command line options.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make passenger_pool_idle_time configurable
3 participants