Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffolding for cached values with job composer #2706

Merged
merged 28 commits into from
Apr 20, 2023
Merged

Scaffolding for cached values with job composer #2706

merged 28 commits into from
Apr 20, 2023

Conversation

Oglopf
Copy link
Contributor

@Oglopf Oglopf commented Mar 29, 2023 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Asana task by Unito

@Oglopf Oglopf changed the title initial commit Scaffolding for cached values with job composer Mar 29, 2023
@Oglopf
Copy link
Contributor Author

Oglopf commented Mar 29, 2023 •
edited
Loading

Relates to #2689

@Oglopf
Copy link
Contributor Author

Oglopf commented Apr 6, 2023 •
edited
Loading

I'm struggling to understand these auto_attributes system tests that fail. I don't know where the default values for that are coming from and I don't see any fixture files that look like thy matter. How were these defaults and the choices for clusters and accounts created?

@Oglopf
Copy link
Contributor Author

Oglopf commented Apr 6, 2023

Yeah this is frustrating. These system tests will pass when run locally, yet fail here. It is like the default values change, but I don't know where that is set.

@sync-by-unito sync-by-unito bot closed this Apr 14, 2023
@johrstrom johrstrom reopened this Apr 14, 2023
@Oglopf Oglopf marked this pull request as ready for review April 20, 2023 14:45
@Oglopf Oglopf mentioned this pull request Apr 20, 2023
Closed
@johrstrom johrstrom self-requested a review April 20, 2023 17:45
johrstrom
johrstrom approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you make another ticket to add tests?

@Oglopf Oglopf mentioned this pull request Apr 20, 2023
Open
@Oglopf Oglopf merged commit 2146e35 into master Apr 20, 2023
@Oglopf Oglopf deleted the cache-form-submission-fields branch April 20, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johrstrom johrstrom johrstrom approved these changes

Assignees

@Oglopf Oglopf

Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oglopf @johrstrom @osc-bot