Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show app card host only for running sessions #3363

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

robinkar
Copy link
Contributor

@robinkar robinkar commented Feb 20, 2024

We're testing OOD 3.1 and I noticed the behaviour for host on app cards changed in #3211.

Upon closer inspection it turns out that if you have SSH to compute nodes disabled the users will see an internal server error on the My interactive sessions page while the job is starting (before connection.yml exists, so session.connect is not safe to call).
image

#<Errno::ENOENT: No such file or directory @ rb_sysopen - /users/robkarls/ondemand/data/sys/dashboard/batch_connect/dev/ood-base-jupyter/output/737014d2-07c4-47ac-b601-f157ba9bf322/connection.yml>

/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:560:in `read'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:560:in `read'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:560:in `connect'
/var/www/ood/apps/sys/dashboard/app/views/batch_connect/sessions/card/_host.html.erb:15:in `_app_views_batch_connect_sessions_card__host_html_erb__2025030219551494985_15040'

Previously the host was only visible for running sessions, but now for everything except running sessions it shows "Undetermined"
Left is 3.0, right is 3.1, compute node shell enabled (i.e. no internal server error here):
host_undetermined

This PR changes that so it behaves as it did previously, i.e. it is only visible for running sessions. There might be some better place to place if session.running?, so the whole template would not be wrapped. Let me know if you'd like me to change that.

@robinkar
Copy link
Contributor Author

To reproduce, add ssh_allow: false to some app form.yml.erb and launch the app.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll get this backported to 3.1 today as well. We're announcing 3.1 today, but can release a 3.1.1 at some point in the near future.

@johrstrom johrstrom merged commit 0d059f8 into OSC:master Feb 20, 2024
20 checks passed
johrstrom added a commit that referenced this pull request Feb 21, 2024
Show app card host only for running sessions (#3363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants