Show app card host only for running sessions #3363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're testing OOD 3.1 and I noticed the behaviour for host on app cards changed in #3211.
Upon closer inspection it turns out that if you have SSH to compute nodes disabled the users will see an internal server error on the My interactive sessions page while the job is starting (before
connection.yml
exists, sosession.connect
is not safe to call).Previously the host was only visible for running sessions, but now for everything except running sessions it shows "Undetermined"
Left is 3.0, right is 3.1, compute node shell enabled (i.e. no internal server error here):
This PR changes that so it behaves as it did previously, i.e. it is only visible for running sessions. There might be some better place to place
if session.running?
, so the whole template would not be wrapped. Let me know if you'd like me to change that.