Added 404 JSON reponse to projects.show method #3674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that the GitHub actions tests are sometimes failing due to the
ProjectsController
test.This seems to the related to the Ajax call to get the project size made by the page after the project has been deleted.
This seems to be a race condition in the test and directory cleanup.
This fix will return a JSON 404 when the project is not available avoiding the redirect and the error due to the missing JSON response for the index page.