fix downloadable? to account for other file types

[johrstrom]

fix downloadable? to account for other file types to work on #3026.

[johrstrom]

To be clear, this removes pipe? while adding file? and putting them on 2 lines.

[Oglopf]

This looks good but do we want to add a test for this? I didn't see anything for it in the test/models/files_test.rb file but wrote this and the change works as expected:

  test "cannot download files that are not downloadable?" do
    Dir.mktmpdir do |dir|
      file = File.join(dir, 'foo.text')
      FileUtils.touch(file)
      # make sure file is not readable, a condition of PosixFile#downloadable?
      FileUtils.chmod(0333, file)

      refute PosixFile.new(file).downloadable?
    end
  end

Unless the test is happening somewhere else that I missed.

[CSC-swesters]

 test "cannot download files that are not downloadable?" do

@Oglopf Looks like a good test, but I'd change the title of it to cannot download files that are not readable, so that it's more descriptive.

[johrstrom]

There's this system test:

ondemand/apps/dashboard/test/system/files_test.rb

Line 618 in b261441

test 'files that are not downloadable' do

that I can add to and add some unit tests too.

[Oglopf]

@johrstrom ah, I missed the systems test. I think that with a unit test in the files_test.rb would be good coverage for this. Makes me wonder if other posix_file coverage is lacking in testing.

[Oglopf]

Looks great!