Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform alerts #3769

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Uniform alerts #3769

merged 4 commits into from
Sep 4, 2024

Conversation

johrstrom
Copy link
Contributor

Fixes #3761 by using flash messages, like Rails does, but triggered & created from javascript.

Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks much better. This looks good.

@johrstrom johrstrom merged commit 2e5495b into master Sep 4, 2024
26 checks passed
@johrstrom johrstrom deleted the uniform-alerts branch September 4, 2024 18:33
ashton22305 pushed a commit that referenced this pull request Sep 19, 2024
Unify alerts to be like Rails flashes instead of modals in an attempt to start to move away from SweetAlert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate alerts in files app
3 participants