adds formatting options for apache and nginx access logs #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfranz
reviewed
Sep 22, 2020
ericfranz
reviewed
Sep 22, 2020
|
Thank you for the PR! I added a few minor comments. @treydock can review the Apache portion when he is available (there is a downtime this morning so it might be a little bit of time). |
treydock
reviewed
Sep 22, 2020
treydock
reviewed
Sep 22, 2020
|
@ericfranz @treydock Thanks for reviewing this. I've made a few changes according to your suggestions. Let me know what you think. Hope your downtime ends soon! Cheers! |
treydock
reviewed
Sep 22, 2020
treydock
reviewed
Sep 23, 2020
|
Looks good to me. |
ericfranz
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration options to enable custom log formatting on apache and nginx access logs. We use the ELK stack at work to parse webserver logs so this is something that was needed from our side. I tried to preserve backwards compatibility with the default filenames, paths and formats used so far.