Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an adapter for Fujitsu TCS #766

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Add an adapter for Fujitsu TCS #766

merged 2 commits into from
Aug 1, 2022

Conversation

mnakao
Copy link
Contributor

@mnakao mnakao commented Jul 19, 2022

This is an adapter for Fujitsu's resource manager, called FUJITSU Software Technical Computing Suite (TCS).
This resource manager is used at the supercomputer Fugaku and several supercomputer centers.
Although the job dependency part is not implemented yet,
I have confirmed that this adapter works with the latest RPM package, ondemand-2.0.27-1 at Fugaku.

┆Issue is synchronized with this Asana task by Unito

@Oglopf Oglopf self-requested a review July 19, 2022 15:26
@Oglopf
Copy link
Contributor

Oglopf commented Jul 19, 2022

Thank you for the contribution!

Given we have no coverage for this resource manager it's great to have. I'm going to start looking this over and will provide any feedback needed tomorrow and open an issue for some testing to be added as well. Again, thank you so much!

Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments that are strictly syntax and convention based. I apologize for the delay and wanted to say thank you again for doing this!

lib/ood_core/job/adapters/fujitsu_tcs.rb Outdated Show resolved Hide resolved
lib/ood_core/job/adapters/fujitsu_tcs.rb Outdated Show resolved Hide resolved
@Oglopf Oglopf merged commit 0095b06 into OSC:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants