Feature/httpd conf cleanup #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The *:443 will catch everything before _default_:443 because * has a higher precedence. See: https://httpd.apache.org/docs/2.4/vhosts/examples.html#default Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
jasperkamerling
force-pushed
the
feature/httpd-conf-cleanup
branch
2 times, most recently
from
83157ff
to
a647bab
Compare
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
jasperkamerling
force-pushed
the
feature/httpd-conf-cleanup
branch
from
a647bab
to
d98c816
Compare
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
jasperkamerling
force-pushed
the
feature/httpd-conf-cleanup
branch
from
9449c0e
to
b5f5313
Compare
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Marcel-Jansen
approved these changes
Feb 1, 2023
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
jasperkamerling
force-pushed
the
feature/httpd-conf-cleanup
branch
from
7bffac0
to
271dd79
Compare
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
jasperkamerling
force-pushed
the
feature/httpd-conf-cleanup
branch
from
271dd79
to
161f3c6
Compare
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
jasperkamerling
force-pushed
the
feature/httpd-conf-cleanup
branch
from
9cfb53e
to
3e17ff3
Compare
smvdheijden
reviewed
Feb 1, 2023
| {{- else }} | ||
| ServerName {{ .Release.Name }}.{{ .Release.Namespace -}} | ||
| {{ end }} | ||
| Listen {{ .Values.httpdSidecar.port }} |
There was a problem hiding this comment.
Wouldn't it make sense to use the default 443 port here, since SSL/TLS is enabled by default in this config?
There was a problem hiding this comment.
only root use is allowed to use ports under 1024. Our goal should be to run everything as non root I think this is a sensible default.
Signed-off-by: Jasper Kamerling <jasper.kamerling@alliander.com>
jasperkamerling
force-pushed
the
feature/httpd-conf-cleanup
branch
from
7b6f9fc
to
1e7e59f
Compare
smvdheijden
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.