Create serviceaccount in GXF chart #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dit zou een 1.4 moeten zijn omdat je er config voor moet aanpassen in je implementaties |
|
In principe niet toch? Door dat ik de values zet is het mogelijk als toevoeging maar niet direct nodig. |
|
Als ik nu een niet default serviceAccountName heb wordt die niet meer opgepakt na deze wijzging. dan moet het serviceAccount.name zijn. |
|
Ja oke dat is wel waar |
jasperkamerling
approved these changes
Feb 8, 2023
Signed-off-by: Jelle Hoffman <jelle.hoffman@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.