Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LMD SOAP Interface #504

Merged
merged 9 commits into from
Dec 9, 2020
Merged

LMD SOAP Interface #504

merged 9 commits into from
Dec 9, 2020

Conversation

ThE-MaRaC
Copy link
Contributor

LMD SOAP Interface implementation: OSGP/Documentation#236

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 12, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@jenkins-ip-10-4-24-184
Copy link
Contributor

Can one of the admins verify this patch?

@ThE-MaRaC ThE-MaRaC mentioned this pull request Nov 12, 2020
Closed
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 12, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@kevinsmeets
Copy link
Contributor

JIRA ticket for review: https://smartsocietyservices.atlassian.net/browse/OC-690

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 17, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@ThE-MaRaC
Fix LMD delete while it is assigned to the device
1b39f21 
Fix EventRepository.findLatestEventForEveryDevice: use LEFT JOIN to select LMD's without any events
@linux-foundation-easycla
Copy link

CLA Missing ID

@ThE-MaRaC ThE-MaRaC mentioned this pull request Nov 17, 2020
Merged
@kevinsmeets
Copy link
Contributor

ok to test

bvdzwet
bvdzwet suggested changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@bvdzwet bvdzwet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution.

Please have a look at my comments, some are suggestions or merely informational, but you'll find a few that require some further updates.
Just let me know if anything needs more clarification, or if you disagree.
I am looking forward to seeing these changes completed and merged into the code base.

...platform/common/glue/steps/ws/core/deviceinstallation/CreateLightMeasurementDeviceSteps.java Outdated Show resolved Hide resolved
...smartgridplatform/adapter/ws/publiclighting/application/mapping/converters/LmdConverter.java Show resolved Hide resolved
...pter/ws/shared/db/domain/repositories/writable/WritableLightMeasurementDeviceRepository.java Show resolved Hide resolved
...in/resources/db/migration/V20201117090000000__Modify_ssld_to_light_measurement_device_fk.sql Show resolved Hide resolved
...platform/common/glue/steps/ws/core/deviceinstallation/CreateLightMeasurementDeviceSteps.java Outdated Show resolved Hide resolved
...smartgridplatform/adapter/ws/publiclighting/application/mapping/converters/LmdConverter.java Outdated Show resolved Hide resolved
...martgridplatform/adapter/ws/publiclighting/application/mapping/converters/SsldConverter.java Show resolved Hide resolved
...tgridplatform/adapter/ws/publiclighting/endpoints/PublicLightingAdHocManagementEndpoint.java Outdated Show resolved Hide resolved
...tgridplatform/adapter/ws/publiclighting/endpoints/PublicLightingAdHocManagementEndpoint.java Outdated Show resolved Hide resolved
...gridplatform/adapter/ws/publiclighting/application/mapping/converters/DeviceMappingTest.java Outdated Show resolved Hide resolved
@JelleHoffman JelleHoffman merged commit 78395a2 into OSGP:development Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvdzwet bvdzwet bvdzwet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThE-MaRaC @jenkins-ip-10-4-24-184 @kevinsmeets @bvdzwet @JelleHoffman