Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the INSPIRE overview file and adding the INSPIRE screenshot #622

Merged
merged 5 commits into from
Oct 20, 2020

Conversation

df-git
Copy link
Contributor

@df-git df-git commented Sep 24, 2020

No description provided.

@df-git
Copy link
Contributor Author

df-git commented Sep 24, 2020

The checks are failing because there is a reference to the re3gistry_overview file that has just been added and it needs to be approved too.

@cvvergara
Copy link
Contributor

I see this one:

2020-09-24T15:26:31.5794726Z (line   39) broken    https://etf-validator.net - 503 Server Error: Service Temporarily Unavailable for url: https://etf-validator.net/

here:
https://github.com/OSGeo/OSGeoLive-doc/runs/1161252637?check_suite_focus=true#step:9:574

the complete section of linkcheck is:

ok        https://inspire.ec.europa.eu/about-inspire/563
(line   17) ok        https://eur-lex.europa.eu/legal-content/EN/TXT/PDF/?uri=CELEX:32007L0002&from=EN
(line   17) redirect  https://www.iso.org - with Found to https://www.iso.org/home.html
(line   19) redirect  https://inspire.ec.europa.eu/Themes - permanently to https://inspire.ec.europa.eu/Themes/Data-Specifications/2892
(line   33) ok        https://wiki.osgeo.org/wiki/INSPIRE
(line   36) ok        https://ec.europa.eu/jrc/en
(line   39) broken    https://etf-validator.net - 503 Server Error: Service Temporarily Unavailable for url: https://etf-validator.net/
(line   66) -local-   ../sponsors_osgeo.html
(line   71) -local-   ../sponsors_osgeo.html
(line   76) -local-   ../sponsors_osgeo.html
(line   39) ok        https://inspire.ec.europa.eu/validator/about/
(line   40) ok        https://inspire-geoportal.ec.europa.eu/
(line   38) ok        https://inspire.ec.europa.eu/registry
(line   25) ok        https://inspire.ec.europa.eu/Data-Models/Data-Specifications/2892

This is not checked because it does not have the http:// or https:// so the link checker does not consider it.

:doc:`Re3gistry <re3gistry_overview>`

I did a double check downloading in my computer and there was no problem, so I will re-run the link tests

doc/overview/inspire_overview.rst Outdated Show resolved Hide resolved
@cvvergara
Copy link
Contributor

I run twice in my computer:

writing output... [ 22%] overview/inspire_overview                                                                                                                                                                               
ok        https://inspire.ec.europa.eu/about-inspire/563
(line   25) ok        https://inspire.ec.europa.eu/Data-Models/Data-Specifications/2892
(line   19) redirect  https://inspire.ec.europa.eu/Themes - permanently to https://inspire.ec.europa.eu/Themes/Data-Specifications/2892
(line   33) ok        https://wiki.osgeo.org/wiki/INSPIRE
(line   17) ok        https://eur-lex.europa.eu/legal-content/EN/TXT/PDF/?uri=CELEX:32007L0002&from=EN
(line   17) redirect  https://www.iso.org - with Found to https://www.iso.org/home.html
(line   39) ok        https://etf-validator.net
(line   66) -local-   ../sponsors_osgeo.html
(line   71) -local-   ../sponsors_osgeo.html
(line   76) -local-   ../sponsors_osgeo.html
(line   36) ok        https://ec.europa.eu/jrc/en
(line   39) ok        https://inspire.ec.europa.eu/validator/about/
(line   40) ok        https://inspire-geoportal.ec.europa.eu/
(line   38) ok        https://inspire.ec.europa.eu/registry

And I dont have problems with the link, https://etf-validator.net
But all the time I ran the actions that link shows:

broken    https://etf-validator.net - 503 Server Error: Service Temporarily Unavailable for url: https://etf-validator.net/

So, its not the only case that issue happens, can you please edit this:
https://github.com/OSGeo/OSGeoLive-doc/blob/master/doc/conf.py#L266
Add the https://etf-validator.net link, where its at, and the error it shows.

@cvvergara
Copy link
Contributor

A preview of how it looks
image

df-git added a commit to df-git/OSGeoLive-doc that referenced this pull request Sep 28, 2020
Updating conf.py, adding a link that exists but when many link checks are done link checker fails 
(as suggested here OSGeo#622 (comment))
@df-git df-git mentioned this pull request Sep 28, 2020
Changing the link as suggested OSGeo#622 (comment)
Copy link
Contributor Author

@df-git df-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fine

@cvvergara cvvergara self-requested a review September 28, 2020 13:52
@cvvergara
Copy link
Contributor

@df-git there is a missing comma at the end of the line of the conf.py

@cvvergara
Copy link
Contributor

This PR can be merged after #621 because it references a project not yet included on the disk

cvvergara added a commit that referenced this pull request Oct 1, 2020
* Update conf.py

Updating conf.py, adding a link that exists but when many link checks are done link checker fails 
(as suggested here #622 (comment))

Added the missing comma

Co-authored-by: Vicky Vergara <vicky@georepublic.de>
@cvvergara cvvergara merged commit 115a525 into OSGeo:master Oct 20, 2020
@cvvergara cvvergara added this to the Release 14.0.0 milestone May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants