r.compress: Reversing logic to fix Failure Reporting #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metzm
reviewed
Aug 21, 2021
raster/r.compress/main.c
Outdated
| @@ -96,7 +96,7 @@ int main(int argc, char *argv[]) | |||
|
|
|||
| stat = EXIT_FAILURE; | |||
There was a problem hiding this comment.
The logic needs to be reversed differently: process() returns 0 on success, 1 on failure. We expect success. If any call to process() fails, we need to exit with EXIT_FAILURE. Thus
stat = EXIT_SUCCESS;
for (n = 0; (name = map->answers[n]); n++)
if (process(name, uncompress->answer))
stat = EXIT_FAILURE;
There was a problem hiding this comment.
@metzm Thanks for the explanation.
I am changing the code accordingly.
|
Thanks for your contribution! |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when recompressing data from one compression to another, everything works but we still get
Exit 1status.This PR reverses the logic of the EXIT_FAILURE and EXIT_SUCCESS status, which fixes #1802.