checks: Fix uninitialized, scope, leak, const issues in C #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overwritten after
lbartoletti
force-pushed
the
various_fixes
branch
from
d0d4c1a
to
1adc17a
Compare
wenzeslaus
reviewed
Mar 5, 2022
wenzeslaus
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
It might be safer for the two mode functions to return nan or inf in case the input is empty, but it is a misuse of the function, so the return value is sort of undefined in that case. You can consider mentioning this in a comment in the code there (lib/calc/xmode.c and xnmode.c).
|
Thanks! Next time, when splitting the work, consider that the commit message summary (PR title) should be descriptive (although I managed to come up with hopefully descriptive enough line at the end; your individual commit messages were very helpful! ...and are included in the commit message body). |
|
OK, thanks! |
wenzeslaus
changed the title
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
* make_loc.c: reduce the scope of the variable 'path' * make_loc.c: remove useless assignment of l_1 and l_2 since they are overwritten after * make_loc.c: l_1 and l_2 are already checked before * xmode.c: mode: initialize mode_v to avoid a false-positive warning * xnmode.c: mode: initialize mode_v to avoid a false-positive warning * gs3.c: Gs_update_attrange: initialize min and max to avoid a false-positive warning * gs3.c: Gs_load_3dview: reduce scope of the variable 'pt' * gs3.c: Gs_load_3dview: const geosurf * mm_utils: MEMORY_LOG: pass str by reference * dataquad.c: quad_data_new: fix memory leak data * dataquad.c: quad_compare: avoid use of null data * dataquad.c: quad_add_data: reduce scope of variables * cr_from_a.c: main: fix resource leak: fp * i.atcorr: various const ref performance * bitmap.c: fix memory leak CWE: 401 * bitmap/sparse.c: fix memory leak CWE: 401 * sparse.c: BM_set_sparse: Tcount is never used * sparse.c: BM_file_write_sparse: reduce scope of cnt * r.terraflow/sweep.h: performs initialization in initialization list * add missing const, various const ref performance Issues detected by clang and cppcheck.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
* make_loc.c: reduce the scope of the variable 'path' * make_loc.c: remove useless assignment of l_1 and l_2 since they are overwritten after * make_loc.c: l_1 and l_2 are already checked before * xmode.c: mode: initialize mode_v to avoid a false-positive warning * xnmode.c: mode: initialize mode_v to avoid a false-positive warning * gs3.c: Gs_update_attrange: initialize min and max to avoid a false-positive warning * gs3.c: Gs_load_3dview: reduce scope of the variable 'pt' * gs3.c: Gs_load_3dview: const geosurf * mm_utils: MEMORY_LOG: pass str by reference * dataquad.c: quad_data_new: fix memory leak data * dataquad.c: quad_compare: avoid use of null data * dataquad.c: quad_add_data: reduce scope of variables * cr_from_a.c: main: fix resource leak: fp * i.atcorr: various const ref performance * bitmap.c: fix memory leak CWE: 401 * bitmap/sparse.c: fix memory leak CWE: 401 * sparse.c: BM_set_sparse: Tcount is never used * sparse.c: BM_file_write_sparse: reduce scope of cnt * r.terraflow/sweep.h: performs initialization in initialization list * add missing const, various const ref performance Issues detected by clang and cppcheck.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* make_loc.c: reduce the scope of the variable 'path' * make_loc.c: remove useless assignment of l_1 and l_2 since they are overwritten after * make_loc.c: l_1 and l_2 are already checked before * xmode.c: mode: initialize mode_v to avoid a false-positive warning * xnmode.c: mode: initialize mode_v to avoid a false-positive warning * gs3.c: Gs_update_attrange: initialize min and max to avoid a false-positive warning * gs3.c: Gs_load_3dview: reduce scope of the variable 'pt' * gs3.c: Gs_load_3dview: const geosurf * mm_utils: MEMORY_LOG: pass str by reference * dataquad.c: quad_data_new: fix memory leak data * dataquad.c: quad_compare: avoid use of null data * dataquad.c: quad_add_data: reduce scope of variables * cr_from_a.c: main: fix resource leak: fp * i.atcorr: various const ref performance * bitmap.c: fix memory leak CWE: 401 * bitmap/sparse.c: fix memory leak CWE: 401 * sparse.c: BM_set_sparse: Tcount is never used * sparse.c: BM_file_write_sparse: reduce scope of cnt * r.terraflow/sweep.h: performs initialization in initialization list * add missing const, various const ref performance Issues detected by clang and cppcheck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes on various error/alert/performance issues spotted by clang and cppcheck (there are others, but I prefer to go step by step and know if it suits you☺️ )