v.info: Add vector name to no db connection message #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is anything still missing here (as it is a draft PR)? |
|
The code does not compile, but the conceptual issue here is that similar message is at many other places, but there it is not possible to get vector map name so easily. |
wenzeslaus
force-pushed
the
vector-name-for-no-table
branch
from
593dceb
to
d5dd993
Compare
|
The code issue is fixed now, but I'm not sure if to introduce this message when we have similar messages but without that additional info. Maybe better more info here is better than consistency with less info. |
wenzeslaus
force-pushed
the
vector-name-for-no-table
branch
from
4c5af50
to
b4e28c8
Compare
The error messegage about missing database connection for a given layer does not include vector name which may not be clear when scripting and an undelying function calls v.info.
wenzeslaus
force-pushed
the
vector-name-for-no-table
branch
from
b4e28c8
to
7482865
Compare
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
The error message about missing database connection for a given layer does not include vector name which may not be clear when scripting or when getting the errors from underlying calls to v.info.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
The error message about missing database connection for a given layer does not include vector name which may not be clear when scripting or when getting the errors from underlying calls to v.info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error messegage about missing database connection for a given layer does not include vector name which may not be clear when scripting and an undelying function calls v.info.