grass.jupyter: Support pathlib.Path in TimeSeriesMap.save #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wenzeslaus
commented
Jun 20, 2022
•
wenzeslaus
commented
- API: TimeSeriesMap.save now supports pathlib.Path objects (and strings as before).
- tests: Use tmp_path, not current dir. Files generated by the tests should use tmp_path (or other pytest tmp dir ways), not the current directory.
wenzeslaus
force-pushed
the
use-tmp-path-for-pytest-results
branch
from
36966dc
to
77b73c9
Compare
chaedri
approved these changes
Feb 11, 2023
wenzeslaus
force-pushed
the
use-tmp-path-for-pytest-results
branch
from
77b73c9
to
50129b2
Compare
wenzeslaus
changed the title
|
The code should actually support both string and Path objects, but it supported only strings, so the new text code broke it. This PR now fixes the code. Writing to the the current works (most of the time), but a file is left in that directory while using pytest tmp dir, the files are managed by pytest and in one place. (They are accessible after the test finishes and are deleted time to time.) |
wenzeslaus
force-pushed
the
use-tmp-path-for-pytest-results
branch
from
50129b2
to
8042302
Compare
Files generated by the tests should use tmp_path (or other pytest tmp dir ways), not the current directory.
…e suffix (extension) instead of manipulating strings. PIL.Image supports Path for 8 years.
wenzeslaus
force-pushed
the
use-tmp-path-for-pytest-results
branch
from
8042302
to
3ca1eb2
Compare
chaedri
approved these changes
Feb 15, 2023
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
When the save method receives a path, ensure the path is pathlib.Path, then use its functions to detect file suffix (extension) instead of manipulating strings. PIL.Image supports Path for 8 years, so we can support that and get the string support by conversion to Path. In tests, use tmp_path, not current dir. Files generated by the tests should use tmp_path (or other pytest tmp dir ways), not the current directory.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
When the save method receives a path, ensure the path is pathlib.Path, then use its functions to detect file suffix (extension) instead of manipulating strings. PIL.Image supports Path for 8 years, so we can support that and get the string support by conversion to Path. In tests, use tmp_path, not current dir. Files generated by the tests should use tmp_path (or other pytest tmp dir ways), not the current directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.