-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch environment: also change mapset #286
Conversation
The bug in r.import is avoided with the second commit, as long as r.proj does not use G_get_window() in the source (input) location + mapset. |
* switch environment: also change mapset * r.proj: use current (target) location + mapset when calling GPJ_init_transform(), needed to get the correct region to be passed as area of interest to PROJ6+
@metzm Thanks for catching this! I searched for further candidates with Question: is this fix also needed in
|
I checked all occurrences of |
* switch environment: also change mapset * r.proj: use current (target) location + mapset when calling GPJ_init_transform(), needed to get the correct region to be passed as area of interest to PROJ6+
* switch environment: also change mapset * r.proj: use current (target) location + mapset when calling GPJ_init_transform(), needed to get the correct region to be passed as area of interest to PROJ6+
To clarify this for anybody who would get the r.import issue: The error message from r.import with default parameters (i.e., extent=input) is:
This is present in 7.8.2 and happens only when r.import really needs to reproject. The PR is merged and the r.import will be fixed in future releases (now available using the development version). Thanks @metzm for the fix! |
Do you mean that there are still open issues in 7.8.2? The fix was backported AFAIK... |
This PR is from January, but 7.8.2 is from December, so I assume the fix is not there, although it might be in the 7.8 branch, but maybe I'm missing something. |
WIP because this exposes a bug in r.import: a temp region with WIND_OVERRIDE can not be used with r.proj/v.proj because the location and mapset need to be switched during reprojection, and the env var WIND_OVERRIDE applies only to the location/mapset where it was established -> unable to find the region def given with WIND_OVERRIDE in the source location/mapset.