Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Avoid overlapping module parameters in Graphical modeler #2991

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

landam
Copy link
Member

@landam landam commented Jun 2, 2023

See #1993

Original behaviour

  • commands with no required parameter (eg. db.databases) do not show automatically (you need to press refresh button)
  • module's input/output parameters are overlapped
Screencast.from.2.6.2023.17.39.39.webm

New behaviour

Screencast.from.2.6.2023.17.27.21.webm

@landam landam added bug Something isn't working GUI wxGUI related labels Jun 2, 2023
@landam landam added this to the 8.3.1 milestone Jun 2, 2023
@landam landam self-assigned this Jun 2, 2023
@landam landam marked this pull request as draft June 2, 2023 10:27
@landam landam linked an issue Jun 2, 2023 that may be closed by this pull request
@landam landam modified the milestones: 8.3.1, 8.3.0 Jun 2, 2023
@landam landam marked this pull request as ready for review June 2, 2023 15:46
@landam landam requested a review from pesekon2 June 2, 2023 15:46
@pesekon2
Copy link
Contributor

pesekon2 commented Jun 4, 2023

All actions in the main window (add a new item, open a module, ...) have a one-click delay at my side.

@wenzeslaus wenzeslaus changed the title Graphical modeler: avoid overlapping module parameters wxGUI: Avoid overlapping module parameters in Graphical modeler Jun 6, 2023
@landam landam modified the milestones: 8.3.0, 8.3.1 Jun 21, 2023
@pesekon2
Copy link
Contributor

@landam: The need for an extra click apparently happens to me even in the main branch. Therefore, it is not connected to this PR.

In all the other aspects, this PR solves the overlapping parameters issue for me. Thanks.

@landam landam modified the milestones: 8.3.1, 8.3.2 Oct 25, 2023
@landam landam merged commit b9efba2 into OSGeo:main Oct 25, 2023
18 checks passed
@landam landam deleted the issue_1993_gmodeler_param_overlap branch October 25, 2023 14:20
landam added a commit to landam/grass that referenced this pull request Oct 25, 2023
…o#2991)

Co-authored-by: Ondrej Pesek <pesej.ondrek@gmail.com>
landam added a commit to landam/grass that referenced this pull request Nov 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Development

Successfully merging this pull request may close these issues.

[Bug] g.gui.modeler: module parameters overlaps
2 participants