-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/preferences: allow the user save/load single-window mode panes layout #3312
wxGUI/preferences: allow the user save/load single-window mode panes layout #3312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it and it works well :-)
I am just thinking about the placement of the new check box because it is actually not the content of Workspace settings.
Maybe we could create a new Layout settings static box and place there things related to the Layout?
Suggestion:
Layout settings ------------------------
- Save current window layout as default
- Save current single window panes layout as default
- Hide 'Tools' tab
- Hide 'History' tab
- Hide 'Python' tab
We might also disable or completely toss out the three "Hide" checkboxes for Single-Window case. I think it is not of any use when there is the new "Save current single window panes layout as default" checkbox. What do you think @tmszi, @petrasovaa ?
Another (simpler) variant coming to my mind, dealing just with this new checkbox, could be to place the new checkbox in the Appearance tab under the Window layout settings static box and enable it only when Use single-window mode is checked. But probably for the future, a rearrangement of the checkboxes I mentioned earlier would be needed anyway.. |
I agree with your suggestion.
Maybe I would leave these three "Hide" checkboxes for single-window mode as well, because they are valid (minimize vs hide). |
Looks great! Thanks @tmszi for changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like when you hide a tab (e.g history) and save layout, then relaunch GUI, uncheck 'hide history tab', then relaunch GUI again, the history tab is not added back. You would have to uncheck 'Save current single window layout...', then the history tab would come back after relaunching. I am not sure though how to fix that.
We could consider removing the option to hide the tabs, it's not super useful for single window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with hiding tabs I mentioned is minor, so I am fine with merging this.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Allow the user save/load single-window mode panes layout.
Closes #3212, #3210.
wxgui_preferences_save_load_single_win_panes_layout.mp4