Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell: Address various shellcheck issues and formatting #3548

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Shell: Address various shellcheck issues and formatting #3548

wants to merge 17 commits into from

Commits on Mar 30, 2024

  1. CI(windows): Address shellcheck warnings in build_osgeo4w.sh

    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    8f192a3 View commit details
    Browse the repository at this point in the history

  2. test: Quote variables in test_thorough.sh

    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    7306341 View commit details
    Browse the repository at this point in the history

  3. CI(ubuntu): Create makecmd variable as an array instead of a string t… 

    …o eval
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    bba2c8c View commit details
    Browse the repository at this point in the history

  4. CI(ubuntu): Sync structure of build_ubuntu-22.04_without_x.sh with bu… 

    …ild_ubuntu-22.04.sh
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    b83fddf View commit details
    Browse the repository at this point in the history

  5. docker(alpine): Incomplete shebang in docker/alpine/grass_tests.sh

    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    5368efb View commit details
    Browse the repository at this point in the history

  6. CI(macOS): Add missing quotes in make command

    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    182478b View commit details
    Browse the repository at this point in the history

  7. CI(macOS): Remove double quotes sandwiched in quoted CONFIGURE_FLAGS. 

    See shellcheck wiki for error SC2140
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    865b79d View commit details
    Browse the repository at this point in the history

  8. docker: Uniformize shell scripts formatting 

    Using `shfmt -w -s -i 4 -ci -bn -sr`
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    ba3b9cd View commit details
    Browse the repository at this point in the history

  9. binder: Double quote variables in postBuild

    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    9594172 View commit details
    Browse the repository at this point in the history

  10. binder: Uniformize shell script formatting 

    Using `shfmt -w -s -i 4 -ci -bn -sr`
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    882ea97 View commit details
    Browse the repository at this point in the history

  11. utils(module_synopsis): Use $(...) notation instead of legacy backtic… 

    …ked command substitution

Fixes SC2006
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    f2c4bdf View commit details
    Browse the repository at this point in the history

  12. utils(module_synopsis): Exit if cd fails

    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    9089e1e View commit details
    Browse the repository at this point in the history

  13. utils(module_synopsis): Double quote $(...) command substitutions

    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    eb93acc View commit details
    Browse the repository at this point in the history

  14. utils(module_synopsis): Disable some shellcheck errors as false posit… 

    …ive or intended
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    9ceeaa4 View commit details
    Browse the repository at this point in the history

  15. utils(module_synopsis): Check exit code directly instead of with $?… 

    … SC2181
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    00e99ae View commit details
    Browse the repository at this point in the history

  16. utils(module_synopsis): Uniformize shell script formatting 

    Using `shfmt -w -s -i 4 -ci -bn -sr`
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    556efc7 View commit details
    Browse the repository at this point in the history

  17. utils(module_synopsis): Disable SC2016 when single-quoting $GISBASE i… 

    …n messages
    @echoix
    echoix committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    cfd93f6 View commit details
    Browse the repository at this point in the history