-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t.rast.neighbors: support all r.neighbors features and allow to append to existing STRDS as well as filtering by region #3798
Conversation
See also #3427 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing n coordinate, tests run successfully. Is there anything else I should test particularly? If yes, an example in the manual page, would be great :)
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
The manual is now also updated with the changes in this PR. |
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested again, within the world_latlong project, all tests are OK. However, see my comment below regarding the warning that is printed when running them. Is this correct?
The fix in 4e6f5bf should probably be backported to 8.4... |
Should this still go into 8.4.0 or 8.4.1? |
I think 8.4.1 can be sufficient as it does not seem to cause issues other places in main. Not sure about addons though... |
@ninsbl I think it's ready, but just before, can you try (locally) if with ruff 0.5.3 there's no changes (PLR17xx something changed and covers a new case than before). I don't think it's worth a full new run of CI, but just check again, it takes less than a second to run ;) |
No changes with ruff 0.5.3 detected... |
…d to existing STRDS as well as filtering by region (OSGeo#3798) * propagate r.neighbors options * reactivate and extend tests * allow to extend existing STRDS * allow spatial selection by computational region --------- Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
This PR:
We may remove the SHELL version of the tests...