CI: Cancel in progress jobs for other workflows #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is quite trivial (simple) to review. Almost anybody can review it right away (it applies the existing pattern in the repo to other files). I can't approve my own PRs, even if I try to take good care of CI. |
nilason
approved these changes
Jun 22, 2024
Merged
kritibirda26
pushed a commit
to kritibirda26/grass
that referenced
this pull request
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This week during the code sprint, I observed that some workflows or jobs weren't cancelled when another push/force push to a PR was made. Most of them didn't have a long runtime, and some were tricky as they continued to be queued after a force push.
Also fixes a small issue where clang-format jobs were cancelled on main (supposed to be a protected branch) when multiple jobs of this typed were queued. Suppose three merges to main made extremely close together, and the first set of jobs start normally. The first one, currently executing, continued, but the second was cancelled, and the third was made "pending", waiting for the first to finish. This PR finally makes use of the same known pattern.