Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.in.pdal: use 1 based return numbers in LAS info output #3907

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

marisn
Copy link
Contributor

@marisn marisn commented Jun 19, 2024

According to LAS specification, the first return number is 1. Fixes #3827

According to LAS specification, the first return number is 1.
Fixes OSGeo#3827
@marisn marisn requested a review from nilason June 19, 2024 18:09
@marisn marisn added the C++ Related code is in C++ label Jun 19, 2024
@marisn marisn added this to the 8.5.0 milestone Jun 19, 2024
@marisn marisn added the backport to 8.4 PR needs to be backported to release branch 8.4 label Jun 19, 2024
@echoix
Copy link
Member

echoix commented Jun 19, 2024

According to the excerpt of the specification in the related issue, this fix is does the right thing!

@echoix echoix enabled auto-merge (squash) June 19, 2024 20:05
@github-actions github-actions bot added raster Related to raster data processing module labels Jun 19, 2024
@echoix echoix merged commit da13452 into OSGeo:main Jun 20, 2024
24 checks passed
@marisn marisn deleted the r_in_pdal_fix_3827 branch June 20, 2024 10:27
cyliang368 pushed a commit to cyliang368/grass that referenced this pull request Jun 22, 2024
According to LAS specification, the first return number is 1.
Fixes OSGeo#3827
neteler pushed a commit that referenced this pull request Jun 25, 2024
According to LAS specification, the first return number is 1.
Fixes #3827
@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Jun 25, 2024
@neteler neteler modified the milestones: 8.5.0, 8.4.0 Jun 25, 2024
@a0x8o a0x8o mentioned this pull request Jun 27, 2024
kritibirda26 pushed a commit to kritibirda26/grass that referenced this pull request Jun 29, 2024
According to LAS specification, the first return number is 1.
Fixes OSGeo#3827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Related code is in C++ module raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r.in.pdal handling the number of returns
4 participants