Checks: fix flake8 E741 in gui/wxpython directory #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've reviewed everything, it's correct, but I'm not completely sure I understand the old code from gui/wxpython/iclass/dialogs.py and gui/wxpython/iscatt/frame.py. As such, I'm not completely sure of the new name chosen. But the form is correct even in these two files. Can someone jump in for this? |
echoix
approved these changes
Jun 28, 2024
cyliang368
pushed a commit
to cyliang368/grass
that referenced
this pull request
Jul 1, 2024
* Rename self.l to self.item_attr when using self.l as an argument to wx.ItemAttr(). * Rename l to layer when using l for loop through layer list. * Rename l to new_layer_lst when using l as an argument to self._tree.AddLayer(). * Rename l to rli_conf when looping through the configuration files in self.rlipath. * Rename l to layer when looping through the self.map_.GetListOfLayers(). * Rename l to dataset_info when sorting `allDatasets` with the lambda function. * Rename l to layer_num when looping through `catsDict.items()`. * Rename l to layer when retrieving layer information in a function. * Rename l to curr when looping through the `curr_sel_ls`. * Remove E741 for files in gui/wxpython directory.
Merged
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 2, 2024
* Rename self.l to self.item_attr when using self.l as an argument to wx.ItemAttr(). * Rename l to layer when using l for loop through layer list. * Rename l to new_layer_lst when using l as an argument to self._tree.AddLayer(). * Rename l to rli_conf when looping through the configuration files in self.rlipath. * Rename l to layer when looping through the self.map_.GetListOfLayers(). * Rename l to dataset_info when sorting `allDatasets` with the lambda function. * Rename l to layer_num when looping through `catsDict.items()`. * Rename l to layer when retrieving layer information in a function. * Rename l to curr when looping through the `curr_sel_ls`. * Remove E741 for files in gui/wxpython directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E741 "ambiguous variable name 'l'" is fixed in the gui/wxpython directory. Many of the fixes involved renaming "l" in iterables.
One thing I would like to point out is that 01eb8dd returns its self value. Personally, I don't see a problem with changing the name, but I thought it would be best to consult with a developer who is familiar with GRASS GUIs.